Skip to content

Add Ringtone and Canned Messages to --export-config and --configure #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 23, 2025

Conversation

pdxlocations
Copy link
Member

This would close #427

Copy link

codecov bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 8 lines in your changes missing coverage. Please review.

Project coverage is 60.13%. Comparing base (c55f1ef) to head (68a2009).
Report is 38 commits behind head on master.

Files with missing lines Patch % Lines
meshtastic/__main__.py 66.66% 6 Missing ⚠️
meshtastic/mesh_interface.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #795      +/-   ##
==========================================
+ Coverage   59.90%   60.13%   +0.22%     
==========================================
  Files          24       24              
  Lines        4163     4187      +24     
==========================================
+ Hits         2494     2518      +24     
  Misses       1669     1669              
Flag Coverage Δ
unittests 60.13% <71.42%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ianmcorvidae ianmcorvidae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Had to get home first, side-by-side was just too unreadable on the phone to go with the earlier reviews/merges, heh

@ianmcorvidae ianmcorvidae merged commit fcdd838 into meshtastic:master Jul 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add RTTL Ringtone to --export-config and --configure
2 participants